Copper6SSP: new adapter #11809
Copper6SSP: new adapter #11809
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
modules/copper6sspBidAdapter.js
Outdated
| syncUrl += '&gpp_sid=' + gppConsent.applicableSections.join(','); | ||
| } | ||
|
|
||
| const coppa = config.getConfig('coppa') ? 1 : 0; |
There was a problem hiding this comment.
Please get this off bidderRequest.ortb2.regs instead of from config
|
This should stay on hold until the teqblaze team commit |
|
Please see #11854 and refactor, thanks! |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
|
Very nice |
* release adapter Copper6SSP * removed code duplication
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
doc - prebid/prebid.github.io#5426